Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Fix compatibility with TM 10 #1469

Merged
merged 5 commits into from
Oct 18, 2022
Merged

Fix compatibility with TM 10 #1469

merged 5 commits into from
Oct 18, 2022

Conversation

ethanwharris
Copy link
Collaborator

@ethanwharris ethanwharris commented Oct 18, 2022 •
edited
Loading

What does this PR do?

Fixes # (issue)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@ethanwharris ethanwharris added the bug / fix Something isn't working label Oct 18, 2022
@ethanwharris ethanwharris added this to the 0.8.x milestone Oct 18, 2022
@ethanwharris ethanwharris changed the title [WIP] Fix compatibility with TM 10 Fix compatibility with TM 10 Oct 18, 2022
@codecov
Copy link

codecov bot commented Oct 18, 2022 •
edited
Loading

Codecov Report

Base: 92.35% // Head: 92.34% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (81ffb23) compared to base (41d1251).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1469      +/-   ##
==========================================
- Coverage   92.35%   92.34%   -0.02%     
==========================================
  Files         291      291              
  Lines       13171    13176       +5     
==========================================
+ Hits        12164    12167       +3     
- Misses       1007     1009       +2
Flag Coverage Δ
pytest 13.07% <12.50%> (+<0.01%) ⬆️
tpu 13.07% <12.50%> (+<0.01%) ⬆️
unittests 92.87% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/core/utilities/imports.py 94.11% <100.00%> (+0.03%) ⬆️
flash/image/segmentation/model.py 94.44% <100.00%> (+0.12%) ⬆️
flash/pointcloud/segmentation/model.py 91.86% <100.00%> (+0.19%) ⬆️
flash/core/serve/dag/task.py 95.81% <0.00%> (-1.05%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ethanwharris ethanwharris merged commit 1d3cb6e into master Oct 18, 2022
@ethanwharris ethanwharris deleted the bugfix/tm_10 branch October 18, 2022 17:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@krshrimali krshrimali krshrimali approved these changes

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@tchaton tchaton Awaiting requested review from tchaton

@justusschock justusschock Awaiting requested review from justusschock

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

Assignees
No one assigned
Labels
bug / fix Something isn't working
Projects
None yet
Milestone
0.8.x
Development

Successfully merging this pull request may close these issues.
2 participants
@ethanwharris @krshrimali